Re: [PATCH 1/3] drm/amdgpu: fix amdgpu_coredump

[Christian König <ckoenig.leichtzumerken@xxxxxxxxx>]

Sunil please take a look as well.

Thanks,
Christian.

Am 13.12.24 um 09:52 schrieb Christian König:
> The VM pointer might already be outdated when that function is called.
> Use the PASID instead to gather the information instead.
>
> Signed-off-by: Christian König <christian.koenig@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> index 946c48829f19..824f9da5b6ce 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> @@ -343,11 +343,10 @@ void amdgpu_coredump(struct amdgpu_device *adev, bool skip_vram_check,
>   	coredump->skip_vram_check = skip_vram_check;
>   	coredump->reset_vram_lost = vram_lost;
>   
> -	if (job && job->vm) {
> -		struct amdgpu_vm *vm = job->vm;
> +	if (job && job->pasid) {
>   		struct amdgpu_task_info *ti;
>   
> -		ti = amdgpu_vm_get_task_info_vm(vm);
> +		ti = amdgpu_vm_get_task_info_pasid(adev, job->pasid);
>   		if (ti) {
>   			coredump->reset_task_info = *ti;
>   			amdgpu_vm_put_task_info(ti);