On Wed, Dec 11, 2024 at 10:56 AM Mario Limonciello <superm1@xxxxxxxxxx> wrote: > > From: Mario Limonciello <mario.limonciello@xxxxxxx> > > If the kernel hasn't been compiled with PCIe hotplug support this > can lead to problems with dGPUs that use BOCO because they effectively > drop off the bus. > > To prevent issues, disable BOCO support when compiled without PCIe hotplug. > > Reported-by: Gabriel Marcano <gabemarcano@xxxxxxxxx> > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1707#note_2696862 > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> Acked-by: Alex Deucher <alexander.deucher@xxxxxxx> Seems like this should affect any device which supports d3cold. Maybe we want something more general as well? Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 764d41434a82f..7db796ebb967e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -419,6 +419,9 @@ bool amdgpu_device_supports_boco(struct drm_device *dev) > { > struct amdgpu_device *adev = drm_to_adev(dev); > > + if (!IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE)) > + return false; > + > if (adev->has_pr3 || > ((adev->flags & AMD_IS_PX) && amdgpu_is_atpx_hybrid())) > return true; > -- > 2.43.0 >
