Hi,
On Wed, Feb 28, 2024 at 11:39:16AM -0700, Alex Hung wrote:
> From: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
>
> [WHY]
> To log commit states and when we transition in/out of allow and idle
> states and the caller.
>
> [HOW]
> Add a new logging helper and wrap idle optimization calls to receive
> the caller.
>
> Reviewed-by: Duncan Ma <duncan.ma@xxxxxxx>
> Acked-by: Alex Hung <alex.hung@xxxxxxx>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
> ---
...
>
> + DC_LOG_ERROR("%s: DMCUB error - collecting diagnostic data\n", __func__);
> +
This patch generates _lots_ of logging noise.
[689208.336969] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689219.628141] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689221.098993] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689222.645994] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689225.341470] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689226.467388] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689226.716755] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689231.507746] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689247.287990] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689252.441150] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
I disabled it in my private kernel build, so no problem for me. However,
searching for the string on the web shows lots of complaints. Not my call
to make, but claiming that this patch adds "debug prints for IPS testing"
seems to be a bit misleading.
Guenter
