[Public] Hi all, This week this patchset was tested on 4 systems, two dGPU and two APU based, and tested across multiple display and connection types. APU * Single Display eDP -> 1080p 60hz, 2560x1600 120hz, 1920x1200 165hz * Single Display DP -> 4k144hz, 4k240hz * Multi display -> eDP + DP/HDMI/USB-C -> 1080p 60hz eDP + 4k 144hz, 4k 240hz (Includes USB-C to DP/HDMI adapters) * Thunderbolt -> LG Ultrafine 5k * DSC -> Cable Matters 101075 (DP to 3x DP) with 3x 4k60hz displays, HP Hook G2 with 2x 4k60hz displays * USB 4 -> HP Hook G4, Lenovo Thunderbolt Dock, both with 2x 4k60hz DP and 1x 4k60hz HDMI displays * SST PCON -> Club3D CAC-1085 + 1x 4k 144hz, FRL3, at a max resolution supported by the dongle of 4k 120hz YUV420 12bpc. * MST PCON -> 1x 4k 144hz, FRL3, at a max resolution supported by the adapter of 4k 120hz RGB 8bpc. DGPU * Single Display DP -> 4k144hz, 4k240hz * Multiple Display DP -> 4k240hz + 4k144hz * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60hz displays) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to) * Changing display configurations and settings * Video/Audio playback * Benchmark testing * Suspend/Resume testing * Feature testing (Freesync, HDCP, etc.) Automated testing includes (but is not limited to) * Script testing (scripts to automate some of the manual checks) * IGT testing The testing is mainly tested on the following displays, but occasionally there are tests with other displays * Samsung G8 Neo 4k240hz * Samsung QN55QN95B 4k 120hz * Acer XV322QKKV 4k144hz * HP U27 4k Wireless 4k60hz * LG 27UD58B 4k60hz * LG 32UN650WA 4k60hz * LG Ultrafine 5k 5k60hz * AU Optronics B140HAN01.1 1080p 60hz eDP * AU Optronics B160UAN01.J 1920x1200 165hz eDP * AU Optronics B160QAN02.L 2560x1600 120hz eDP The patchset consists of the amd-staging-drm-next branch (Head commit - 32a8dc1b252b9066366a27d3d9ce571278212418 -> drm/amdgpu: rework resume handling for display (v2)) with new patches added on top of it. Tested on Ubuntu 24.04.1, on Wayland and X11, using KDE Plasma and Gnome. Thank you, Dan Wheeler Sr. Technologist | AMD SW Display ------------------------------------------------------------------------------------------------------------------ 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -----Original Message----- From: Aurabindo Pillai <aurabindo.pillai@xxxxxxx> Sent: Tuesday, December 3, 2024 4:40 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>; Lin, Wayne <Wayne.Lin@xxxxxxx>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@xxxxxxx>; Zuo, Jerry <Jerry.Zuo@xxxxxxx>; Mohamed, Zaeem <Zaeem.Mohamed@xxxxxxx>; Chiu, Solomon <Solomon.Chiu@xxxxxxx>; Wheeler, Daniel <Daniel.Wheeler@xxxxxxx> Subject: [PATCH 00/19] DC Patches for 6 Dec 2024 This DC patchset brings improvements in multiple areas. In summary, we have: * Fix some regressions related to IPS2 and PSR Panel Replay * Bug fixes in DML * DMCUB debug improvements * Other refactors and improvements across multiple components Cc: Daniel Wheeler <daniel.wheeler@xxxxxxx> ________________ Aric Cyr (1): drm/amd/display: 3.2.313 Ausef Yousof (1): drm/amd/display: Overwriting dualDPP UBF values before usage Austin Zheng (1): drm/amd/display: DML21 Update Prefetch Calculations Charlene Liu (1): drm/amd/display: update dcn351 used clock offset Chris Park (1): drm/amd/display: Update color space, bias and scale programming sequence Gabe Teeger (1): Revert "drm/amd/display: Revised for Replay Pseudo vblank" Harry VanZyllDeJong (1): drm/amd/display: populate VABC support in DMCUB Joshua Aberback (1): drm/amd/display: Refactor dcn31_panel_construct to avoid assert Karthi Kandasamy (1): drm/amd/display: expose DCN401 HUBP functions Leo Li (1): drm/amd/display: Make DMCUB tracebuffer debugfs chronological Nicholas Kazlauskas (2): Revert "drm/amd/display: Don't allow IPS2 in D0 for RCG Dynamic" drm/amd/display: Fix DML2 out_states to match in_states for DCN35/DCN351 Peterson (1): drm/amd/display: Use resource_build_scaling_params for dcn20 Samson Tam (1): drm/amd/display: clean up SPL code Taimur Hassan (1): drm/amd/display: [FW Promotion] Release 0.0.246.0 Wayne Lin (3): drm/amd/display: Adjust dc_stream_forward_crc_window to accept assignment of phy_id drm/amd/display: Fix phy id mapping issue for secure display drm/amd/display: Adjust secure_display_context data structure Zhongwei (1): drm/amd/display: remove clearance code of force_ffu_mode flag in dmub_psr_copy_settings() .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 8 +- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 327 ++++++++++++++++-- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h | 25 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 26 +- .../gpu/drm/amd/display/dc/clk_mgr/Makefile | 2 +- .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 5 +- .../display/dc/clk_mgr/dcn35/dcn351_clk_mgr.c | 140 ++++++++ .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 132 +++++-- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.h | 4 + drivers/gpu/drm/amd/display/dc/core/dc.c | 8 +- drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 5 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 1 - .../gpu/drm/amd/display/dc/dc_spl_translate.c | 9 +- drivers/gpu/drm/amd/display/dc/dc_stream.h | 1 + drivers/gpu/drm/amd/display/dc/dc_types.h | 4 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 3 +- .../amd/display/dc/dcn31/dcn31_panel_cntl.c | 34 +- .../amd/display/dc/dml2/display_mode_core.c | 30 +- .../dc/dml2/display_mode_core_structs.h | 6 +- .../src/dml2_core/dml2_core_dcn4_calcs.c | 11 + .../display/dc/dml2/dml2_translation_helper.c | 15 +- .../amd/display/dc/hubp/dcn401/dcn401_hubp.c | 20 +- .../amd/display/dc/hubp/dcn401/dcn401_hubp.h | 23 ++ .../amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 1 + .../amd/display/dc/inc/hw/clk_mgr_internal.h | 59 ++++ .../dc/resource/dcn20/dcn20_resource.c | 57 +-- drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 71 ++-- .../gpu/drm/amd/display/dc/spl/dc_spl_types.h | 6 +- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 3 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 154 ++++++--- .../gpu/drm/amd/display/dmub/src/dmub_srv.c | 4 - .../amd/display/modules/power/power_helpers.c | 4 +- .../amd/display/modules/power/power_helpers.h | 2 +- 35 files changed, 919 insertions(+), 300 deletions(-) create mode 100644 drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn351_clk_mgr.c -- 2.47.1