On 12/6/2024 1:46 AM, Pratap Nirujogi wrote:
> ISP hw_init is not called with the recent changes releated
> to hw init levels. AMDGPU_INIT_LEVEL_DEFAULT is ignoring
> the ISP IP block as AMDGPU_IP_BLK_MASK_ALL is derived using
> incorrect max number of IP blocks.
>
> Update AMDGPU_IP_BLK_MASK_ALL to use AMD_IP_BLOCK_TYPE_NUM
> instead of AMDGPU_MAX_IP_NUM to fix the issue.
>
> Fixes: 14c11b71985c ("drm/amdgpu: Add init levels")
> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@xxxxxxx>
Reviewed-by: Lijo Lazar <lijo.lazar@xxxxxxx>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 735a01c58cd7..b5208a16d7d4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -144,7 +144,7 @@ const char *amdgpu_asic_name[] = {
> "LAST",
> };
>
> -#define AMDGPU_IP_BLK_MASK_ALL GENMASK(AMDGPU_MAX_IP_NUM - 1, 0)
> +#define AMDGPU_IP_BLK_MASK_ALL GENMASK(AMD_IP_BLOCK_TYPE_NUM - 1, 0)
> /*
> * Default init level where all blocks are expected to be initialized. This is
> * the level of initialization expected by default and also after a full reset
