On Thu, Dec 5, 2024 at 12:05 PM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:
>
> With the warning from the core about missing firmware gone, users still
> may be notified of missing optional firmware by a more friendly message
> to clarify it's optional.
>
> Suggested-by: Lijo Lazar <lijo.lazar@xxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> index ffbb3377e0f6..cf700824b960 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -1459,8 +1459,11 @@ int amdgpu_ucode_request(struct amdgpu_device *adev, const struct firmware **fw,
>
> if (required == AMDGPU_UCODE_REQUIRED)
> r = request_firmware(fw, fname, adev->dev);
> - else
> + else {
> r = firmware_request_nowarn(fw, fname, adev->dev);
> + if (r)
> + drm_info(&adev->ddev, "Optional firmware \"%s\" was not found\n", fname);
> + }
> if (r)
> return -ENODEV;
>
> --
> 2.34.1
>
