On 11/19/2024 11:18 AM, Kenneth Feng wrote:
> skip the power source check on smu v14.0.2/3
>
> Signed-off-by: Kenneth Feng <kenneth.feng@xxxxxxx>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c
> index 5460f8e62264..b60837bd259f 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c
> @@ -1365,6 +1365,10 @@ int smu_v14_0_set_power_source(struct smu_context *smu,
> {
> int pwr_source;
>
> + if ((amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(14, 0, 2)) ||
> + (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(14, 0, 3)))
> + return 0;
> +
.set_power_source = smu_v14_0_set_power_source
The right way is to set this to NULL or remove this line.
Thanks,
Lijo
> pwr_source = smu_cmn_to_asic_specific_index(smu,
> CMN2ASIC_MAPPING_PWR,
> (uint32_t)power_src);
