> -----Original Message----- > From: Huang Rui [mailto:ray.huang at amd.com] > Sent: Friday, May 05, 2017 2:47 PM > To: Yu, Xiangliang <Xiangliang.Yu at amd.com> > Cc: amd-gfx at lists.freedesktop.org; Wang, Daniel(Xiaowei) > <Daniel.Wang2 at amd.com> > Subject: Re: [PATCH 4/6] drm/amdgpu/psp: Do not load asd for SRIOV > > On Thu, May 04, 2017 at 02:36:35PM +0800, Xiangliang Yu wrote: > > If psp version doesn't match asd version, asd loading will be failed. > > Add workaround to bypass it for sriov. > > > > Signed-off-by: Daniel Wang <Daniel.Wang2 at amd.com> > > Signed-off-by: Xiangliang Yu <Xiangliang.Yu at amd.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > index ac5e92e..5041073 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > @@ -230,6 +230,13 @@ static int psp_asd_load(struct psp_context *psp) > > int ret; > > struct psp_gfx_cmd_resp *cmd; > > > > + /* If PSP version doesn't match ASD version, asd loading will be failed. > > + * add workaround to bypass it for sriov now. > > + * TODO: add version check to make it common > > + */ > > Which psp version? Firmware or boot loader? Can you explain clear? SRIOV doesn't care about ASD, I'll remove the comments later to avoid confusing.
