[Public] This patch is, Reviewed-by: Tim Huang <tim.huang@xxxxxxx> > -----Original Message----- > From: Jesse.Zhang <Jesse.Zhang@xxxxxxx> > Sent: Monday, November 11, 2024 5:04 PM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian > <Christian.Koenig@xxxxxxx>; Prosyak, Vitaly <Vitaly.Prosyak@xxxxxxx>; > Huang, Tim <Tim.Huang@xxxxxxx>; Zhang, Jesse(Jie) > <Jesse.Zhang@xxxxxxx> > Subject: [PATCH] drm/amdgpu: fix a mistake when removing > mem_info_preempt_used sysfs > > From: "Jesse.zhang@xxxxxxx" <jesse.zhang@xxxxxxx> > > Skip removing mem_info_preempt_used sysfs when unplugging the device. > > Signed-off-by: Jesse Zhang <jesse.zhang@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c > index 33a714ddfbbc..9a0346ed6ea4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c > @@ -138,7 +138,7 @@ void amdgpu_preempt_mgr_fini(struct > amdgpu_device *adev) > if (ret) > return; > > - if (!drm_dev_enter(adev_to_drm(adev), &idx)) { > + if (drm_dev_enter(adev_to_drm(adev), &idx)) { > device_remove_file(adev->dev, > &dev_attr_mem_info_preempt_used); > drm_dev_exit(idx); > } > -- > 2.25.1