On Tue Nov 5, 2024 at 2:51 AM PST, Dmitry Baryshkov wrote: > On Tue, 5 Nov 2024 at 10:15, Christopher Snowhill <chris@xxxxxxxxxx> wrote: > > > > On Mon Nov 4, 2024 at 12:52 PM PST, André Almeida wrote: > > > Hi Christopher, > > > > > > Em 03/11/2024 03:36, Christopher Snowhill escreveu: > > > > On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote: > > > >> Currently, DRM atomic uAPI allows only primary planes to be flipped > > > >> asynchronously. However, each driver might be able to perform async > > > >> flips in other different plane types. To enable drivers to set their own > > > >> restrictions on which type of plane they can or cannot flip, use the > > > >> existing atomic_async_check() from struct drm_plane_helper_funcs to > > > >> enhance this flexibility, thus allowing different plane types to be able > > > >> to do async flips as well. > > > >> > > > >> In order to prevent regressions and such, we keep the current policy: we > > > >> skip the driver check for the primary plane, because it is always > > > >> allowed to do async flips on it. > > > >> > > > >> Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxx> > > > > > > > > Should I do a R-b too? > > > > > > If you can review the code, it's always really appreciated. > > > > I mean, I did review your changes, they looked good to me. I just didn't > > know the protocol for reporting review in addition to testing. > > Please respond with the R-B tag. Also ideally the Tested-by should > contain the reference to a platform which was used to test it. > > > > > > > > > > The changes looked sound enough for me to feel > > > > like testing it as well. Tested Borderlands Game of the Year Enhanced on > > > > my RX 7700 XT at maximum settings at 1080p165, and the tearing support in > > > > labwc allowed it to reach over 700fps. No problems from the hardware > > > > cursor. > > > > > > Thanks for testing and reporting! > > > > > > > > > > > Tested-by: Christopher Snowhill <chris@xxxxxxxxxx> > > > > > > Reviewed-by: Christopher Snowhill <chris@xxxxxxxxxx> Tested-by: Christopher Snowhill <chris@xxxxxxxxxx> on Radeon RX 7700 XT using labwc-git (I must admit, the documents do not make it clear what format the Testing-by tag should take, or how to append which hardware it was tested on, etc.)
