RE: [PATCH] drm/amdgpu: Fix DPX valid mode check on GC 9.4.3

["Zhang, Hawking" <Hawking.Zhang@xxxxxxx>]

[AMD Official Use Only - AMD Internal Distribution Only]

Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>

 

Regards,
Hawking

-----Original Message-----
From: Lazar, Lijo <Lijo.Lazar@xxxxxxx>
Sent: Monday, November 4, 2024 13:11
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Kamal, Asad <Asad.Kamal@xxxxxxx>
Subject: [PATCH] drm/amdgpu: Fix DPX valid mode check on GC 9.4.3

 

For DPX mode, the number of memory partitions supported should be less than or equal to 2.

 

Signed-off-by: Lijo Lazar <lijo.lazar@xxxxxxx>

Fixes: 1589c82a1085 ("drm/amdgpu: Check memory ranges for valid xcp mode")

---

drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c b/drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c

index fccccea0d2d0..e157d6d857b6 100644

--- a/drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c

+++ b/drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c

@@ -548,7 +548,7 @@ static bool __aqua_vanjaram_is_valid_mode(struct amdgpu_xcp_mgr *xcp_mgr,

         case AMDGPU_SPX_PARTITION_MODE:

                 return adev->gmc.num_mem_partitions == 1 && num_xcc > 0;

         case AMDGPU_DPX_PARTITION_MODE:

-               return adev->gmc.num_mem_partitions != 8 && (num_xcc % 4) == 0;

+               return adev->gmc.num_mem_partitions <= 2 && (num_xcc % 4) == 0;

         case AMDGPU_TPX_PARTITION_MODE:

                 return (adev->gmc.num_mem_partitions == 1 ||

                         adev->gmc.num_mem_partitions == 3) &&

--

2.25.1