[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Yang Wang <kevinyang.wang@xxxxxxx>
Best Regards,
Kevin
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex Deucher
Sent: Thursday, October 31, 2024 12:03 AM
To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/3] drm/amdgpu: Adjust debugfs register access permissions
Ping on this series?
Alex
On Mon, Oct 28, 2024 at 10:42 AM Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
>
> Ping on this series?
>
> Alex
>
> On Wed, Oct 23, 2024 at 5:04 PM Alex Deucher <alexander.deucher@xxxxxxx> wrote:
> >
> > Regular users shouldn't have read access.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > index 6e6092916d4e..e44a44405266 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > @@ -1654,7 +1654,7 @@ int amdgpu_debugfs_regs_init(struct amdgpu_device *adev)
> >
> > for (i = 0; i < ARRAY_SIZE(debugfs_regs); i++) {
> > ent = debugfs_create_file(debugfs_regs_names[i],
> > - S_IFREG | 0444, root,
> > + S_IFREG | 0400, root,
> > adev, debugfs_regs[i]);
> > if (!i && !IS_ERR_OR_NULL(ent))
> > i_size_write(ent->d_inode, adev->rmmio_size);
> > --
> > 2.46.2
> >
