On 2024-10-29 02:52, Feng, Kenneth wrote: > However, I think it would be better to add the setting of > OverDriveTable.FanZeroRpmStopTemp for this interface. > OverDriveTable.FanZeroRpmStopTemp determines if the fan can stop when > the temperature is below this temperature setting(in the condition > that zero RPM is enabled). > It makes this interface more advanced. OverDriveTable.FanZeroRpmEnable > and OverDriveTable.FanZeroRpmStopTemp are a pair to be arbitered in > pmfw. Sure, that sounds good to me. I'll add a second commit implementing this. With two settings now exposed I also think it'd be better to rename the knob from fan_zero_rpm to fan_zero_rpm_enable. Makes its purpose a whole lot clearer and is in line with the name in OverDriveTable. I'll send v2 along with these changes sometime today. Thanks for the feedback! -- Wolf
