On 10/21/2024 10:11 PM, Deucher, Alexander wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
-----Original Message-----
From: Khatri, Sunil <Sunil.Khatri@xxxxxxx>
Sent: Friday, October 18, 2024 10:07 AM
To: Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander
<Alexander.Deucher@xxxxxxx>; Liu, Leo <Leo.Liu@xxxxxxx>; Lazar, Lijo
<Lijo.Lazar@xxxxxxx>
Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH v6 00/12] validate/clean the functions of ip funcs
On 10/18/2024 7:08 PM, Christian König wrote:
Patches #2, #3 and #12 are Acked-by: Christian König
<christian.koenig@xxxxxxx>
The rest are Reviewed-by: Christian König <christian.koenig@xxxxxxx>
Maybe give others till Monday to take a look as well, could be that
Alex, Lijo or somebody else point out that we are ignoring the suspend
return code during XGMI hive reset for a good reason.
If nobody objects by Monday feel free to commit the whole series.
Sure Christian, Thanks for review. Will wait till Monday evening and if no objections i
will commit.
The return codes from hw_fini and suspend were ignored because we want to make sure all of the IPs are put into a quiescent state. If one of them has a problem, we don't want to skip the rest. Whether or not we should just swallow the errors or save then and then return a error after everything is suspended is open to debate.
As discussed with you Alex. We have reverted it back to the original
behavior. So it will quies as expected if any ip fails and continue to
progress for other IPs.
Regards
Sunil Khatri
Alex
Thanks,
Christian.
Am 18.10.24 um 15:23 schrieb Sunil Khatri:
v6: Fixed the missing return statement on suspend and update the code
with V5 comments.
v5: Fixed review comments. Dropped hw_fini patch and need to look
further why such functions exists. hw_init/hw_fini are mandatory
functions and we should have a valid definition.
v4: hw_init/hw_fini functions are mandatory and raise error message
if
these functions are not defined.
v3: Added 2 new patches to clean get_clocking_state and hw_init
validation.
Sunil Khatri (12):
drm/amdgpu: validate hw_fini before function call
drm/amdgpu: return error if phase2 suspend fails
drm/amdgpu: return error on suspend failure
drm/amdgpu: validate suspend before function call
drm/amdgpu: validate resume before function call
drm/amdgpu: validate wait_for_idle before function call
drm/amdgpu: clean the dummy resume functions
drm/amdgpu: clean the dummy suspend functions
drm/amdgpu: clean the dummy wait_for_idle functions
drm/amdgpu: clean the dummy soft_reset functions
drm/amdgpu: Clean the functions pointer set as NULL
drm/amdgpu: clean unused functions of uvd/vcn/vce
drivers/gpu/drm/amd/amdgpu/aldebaran.c | 24 +-
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 16 -
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 150 ++++++----
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 25 --
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 -
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 10 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 2 -
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 19 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 2 -
drivers/gpu/drm/amd/amdgpu/cik.c | 15 +-
drivers/gpu/drm/amd/amdgpu/cik_ih.c | 3 -
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 3 -
drivers/gpu/drm/amd/amdgpu/cz_ih.c | 3 -
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 9 -
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 9 -
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 9 -
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 9 -
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 9 -
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 2 -
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 -
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 6 -
drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 6 -
drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 6 -
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 2 -
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 -
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 -
drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 3 -
drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 3 -
drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 3 -
drivers/gpu/drm/amd/amdgpu/ih_v7_0.c | 3 -
drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 7 -
drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 14 -
drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 7 -
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 7 -
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 7 -
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 7 -
drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c | 7 -
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 -
drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 3 -
drivers/gpu/drm/amd/amdgpu/nv.c | 14 -
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 3 -
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 3 -
drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 1 -
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/si.c | 21 --
drivers/gpu/drm/amd/amdgpu/si_dma.c | 3 -
drivers/gpu/drm/amd/amdgpu/si_ih.c | 3 -
drivers/gpu/drm/amd/amdgpu/sienna_cichlid.c | 30 +-
drivers/gpu/drm/amd/amdgpu/smu_v13_0_10.c | 20 +-
drivers/gpu/drm/amd/amdgpu/soc15.c | 14 -
drivers/gpu/drm/amd/amdgpu/soc21.c | 14 -
drivers/gpu/drm/amd/amdgpu/soc24.c | 12 -
drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 -
drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 3 -
drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 3 -
drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 3 -
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 3 -
drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 275
------------------
drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 3 -
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 -
drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 274
-----------------
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 5 -
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 5 -
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 10 -
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 5 -
drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 5 -
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 5 -
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 5 -
drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 5 -
drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 1 -
drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 1 -
drivers/gpu/drm/amd/amdgpu/vi.c | 14 -
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -
drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 15 -
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 8 -
.../gpu/drm/amd/pm/powerplay/amd_powerplay.c | 14 -
78 files changed, 114 insertions(+), 1122 deletions(-)
