Hi Gerd,
I did not have the change to follow through the discussion.
Pardon if my suggestion have already been discussed.
On 2 May 2017 at 14:34, Gerd Hoffmann <kraxel at redhat.com> wrote:
> It's unused.
>
> Suggested-by: Daniel Vetter <daniel.vetter at intel.com>
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> ---
> include/uapi/drm/drm_fourcc.h | 2 --
> drivers/gpu/drm/drm_fourcc.c | 3 +--
> drivers/gpu/drm/drm_framebuffer.c | 2 +-
> 3 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 995c8f9c69..305bc34be0 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -33,8 +33,6 @@ extern "C" {
> #define fourcc_code(a, b, c, d) ((__u32)(a) | ((__u32)(b) << 8) | \
> ((__u32)(c) << 16) | ((__u32)(d) << 24))
>
> -#define DRM_FORMAT_BIG_ENDIAN (1<<31) /* format is big endian instead of little endian */
> -
Weston references DRM_FORMAT_BIG_ENDIAN thus this patch will lead to
build breakage.
That is never fun, so please carefully coordinate with the Weston devs
to minimise the fireworks.
Personally I would leave the symbol, since it's UAPI and document that
should not be used. Not my call, so feel free to ignore.
Thanks
Emil
