Re: [PATCH v1] drm/amdgpu: Clean up duplicate ip_block object

[Alex Deucher <alexdeucher@xxxxxxxxx>]

Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

On Thu, Oct 3, 2024 at 9:50 AM Sunil Khatri <sunil.khatri@xxxxxxx> wrote:
>
> remove the duplicate ip_block object in the
> isp_hw_init function.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
> index 416e8b3fad79..adc0b80ca5db 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
> @@ -54,12 +54,6 @@ static int isp_hw_init(struct amdgpu_ip_block *ip_block)
>         struct amdgpu_device *adev = ip_block->adev;
>         struct amdgpu_isp *isp = &adev->isp;
>
> -       const struct amdgpu_ip_block *ip_block =
> -               amdgpu_device_ip_get_ip_block(adev, AMD_IP_BLOCK_TYPE_ISP);
> -
> -       if (!ip_block)
> -               return -EINVAL;
> -
>         if (isp->funcs->hw_init != NULL)
>                 return isp->funcs->hw_init(isp);
>
> --
> 2.34.1
>