Re: [PATCH v6 10/10] drm/amd/display: Fetch the EDID from _DDC if available for eDP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mario,

kernel test robot noticed the following build warnings:

[auto build test WARNING on amd-pstate/linux-next]
[also build test WARNING on amd-pstate/bleeding-edge linus/master v6.11]
[cannot apply to next-20240913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/drm-amd-display-switch-amdgpu_dm_connector-to-use-struct-drm_edid/20240912-093827
base:   https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
patch link:    https://lore.kernel.org/r/20240911213537.2338164-11-superm1%40kernel.org
patch subject: [PATCH v6 10/10] drm/amd/display: Fetch the EDID from _DDC if available for eDP
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240916/202409161225.xuQVKkoR-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240916/202409161225.xuQVKkoR-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409161225.xuQVKkoR-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c: In function 'dm_helpers_probe_acpi_edid':
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:883:28: warning: unused variable 'ddev' [-Wunused-variable]
     883 |         struct drm_device *ddev = connector->dev;
         |                            ^~~~


vim +/ddev +883 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c

   878	
   879	static int
   880	dm_helpers_probe_acpi_edid(void *data, u8 *buf, unsigned int block, size_t len)
   881	{
   882		struct drm_connector *connector = data;
 > 883		struct drm_device *ddev = connector->dev;
   884		struct acpi_device *acpidev = ACPI_COMPANION(ddev->dev);
   885		unsigned char start = block * EDID_LENGTH;
   886		void *edid;
   887		int r;
   888	
   889		if (!acpidev)
   890			return -ENODEV;
   891	
   892		/* fetch the entire edid from BIOS */
   893		r = acpi_video_get_edid(acpidev, ACPI_VIDEO_DISPLAY_LCD, -1, &edid);
   894		if (r < 0) {
   895			DRM_DEBUG_KMS("Failed to get EDID from ACPI: %d\n", r);
   896			return r;
   897		}
   898		if (len > r || start > r || start + len > r) {
   899			r = -EINVAL;
   900			goto cleanup;
   901		}
   902	
   903		memcpy(buf, edid + start, len);
   904		r = 0;
   905	
   906	cleanup:
   907		kfree(edid);
   908	
   909		return r;
   910	}
   911	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux