[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (HP Hook G4 and Lenovo Thunderbolt Dock, both with 1x 4k60 DP and 1x 4k60 HDMI displays) * PCON (Club3D CAC-1085 and 1x 4k 144Hz) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 5dcbd744fdb998108275159acde7685387cec026 -> drm/amd/pm: fix the pp_dpm_pcie issue on smu v14.0.2/3) with new patches added on top of it. Tested on Ubuntu 24.04.1, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx> Thank you, Dan Wheeler Sr. Technologist | AMD SW Display ------------------------------------------------------------------------------------------------------------------ 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -----Original Message----- From: Hung, Alex <Alex.Hung@xxxxxxx> Sent: Wednesday, September 11, 2024 12:21 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Mahfooz, Hamza <Hamza.Mahfooz@xxxxxxx>; Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>; Lin, Wayne <Wayne.Lin@xxxxxxx>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@xxxxxxx>; Zuo, Jerry <Jerry.Zuo@xxxxxxx>; Mohamed, Zaeem <Zaeem.Mohamed@xxxxxxx>; Chiu, Solomon <Solomon.Chiu@xxxxxxx>; Wheeler, Daniel <Daniel.Wheeler@xxxxxxx>; Hung, Alex <Alex.Hung@xxxxxxx> Subject: [PATCH 00/23] DC Patches Sept 11, 2024 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Fixes on DCN35, DCN401 and IPS - Enhancements in DMUB and DSC - Misc fixes for Coverity errors Cc: Daniel Wheeler <daniel.wheeler@xxxxxxx> Alex Hung (2): drm/amd/display: Check null pointer before dereferencing se drm/amd/display: Remove always-false branches Aric Cyr (2): drm/amd/display: 3.2.300 drm/amd/display: 3.2.301 Aurabindo Pillai (1): drm/amd/display: Fix underflow when setting underscan on DCN401 Charlene Liu (2): drm/amd/display: Use full update for swizzle mode change drm/amd/display: Clear cached watermark after resume Daniel Sa (1): drm/amd/display: Emulate Display Hotplug Hang Dillon Varone (1): drm/amd/display: Block timing sync for different output formats in pmo Leo Ma (1): drm/amd/display: Add HDMI DSC native YCbCr422 support Martin Tsai (1): drm/amd/display: Clean up dsc blocks in accelerated mode Nicholas Kazlauskas (1): drm/amd/display: Block dynamic IPS2 on DCN35 for incompatible FW versions Peichen Huang (1): drm/amd/display: Restructure dpia link training Relja Vojvodic (1): drm/amd/display: Add fullscreen only sharpening policy Robin Chen (1): drm/amd/display: Round calculated vtotal Roman Li (2): drm/amd/display: Add dmub hpd sense callback drm/amd/display: Update IPS default mode for DCN35/DCN351 Ryan Seto (1): drm/amd/display: Implement new DPCD register handling Samson Tam (2): drm/amd/display: Use SDR white level to calculate matrix coefficients drm/amd/display: Add debug options to change sharpen policies Sung Joon Kim (1): drm/amd/display: Disable SYMCLK32_LE root clock gating Yihan Zhu (1): drm/amd/display: Enable DML2 override_det_buffer_size_kbytes Zhikai Zhai (1): drm/amd/display: Skip to enable dsc if it has been off .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 70 +++++++++++---- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +- .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 9 +- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 6 ++ drivers/gpu/drm/amd/display/dc/core/dc.c | 41 ++++++++- drivers/gpu/drm/amd/display/dc/dc.h | 14 ++- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 12 +++ drivers/gpu/drm/amd/display/dc/dc_dsc.h | 4 +- .../gpu/drm/amd/display/dc/dc_spl_translate.c | 14 ++- .../dc/dml/dcn20/display_rq_dlg_calc_20.c | 3 - .../dc/dml/dcn20/display_rq_dlg_calc_20v2.c | 3 - .../dc/dml/dcn31/display_mode_vba_31.c | 9 -- .../dc/dml2/dml21/dml21_translation_helper.c | 4 +- .../dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c | 8 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 15 ++-- .../display/dc/hubbub/dcn35/dcn35_hubbub.c | 1 + .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 50 +++++++++++ .../amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 14 +++ .../amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 13 +++ .../amd/display/dc/link/hwss/link_hwss_dpia.c | 31 ++++++- .../drm/amd/display/dc/link/link_validation.c | 7 ++ .../dc/link/protocols/link_dp_capability.c | 5 ++ .../dc/link/protocols/link_dp_training.c | 80 +++++++++++++++-- .../dc/link/protocols/link_dp_training.h | 16 +++- .../link/protocols/link_dp_training_8b_10b.c | 21 +++-- .../dc/link/protocols/link_dp_training_dpia.c | 64 ++++++++------ .../dc/link/protocols/link_dp_training_dpia.h | 19 +++++ .../dc/resource/dcn35/dcn35_resource.c | 1 + .../dc/resource/dcn351/dcn351_resource.c | 3 +- drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 54 ++++++++---- .../display/dc/spl/dc_spl_isharp_filters.c | 85 +++++++++++++++++-- .../display/dc/spl/dc_spl_isharp_filters.h | 9 +- .../gpu/drm/amd/display/dc/spl/dc_spl_types.h | 15 +++- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 25 +++++- .../gpu/drm/amd/display/dmub/src/dmub_dcn35.c | 1 + .../amd/display/modules/freesync/freesync.c | 2 +- 38 files changed, 588 insertions(+), 147 deletions(-) -- 2.34.1