On 9/10/2024 10:45 AM, Jane Jian wrote:
> write OP of HDP_DEBUG1(0x3fbc) is no longer functional, so remove it.
>
You may copy the title/description from the one I shared -
Subj: Remove unneeded write in JPEG v4.0.3
Desc:
HDP_DEBUG1(offset = 0x3fbc) is no longer functional, remove the
redundant write.
> Signed-off-by: Jane Jian <Jane.Jian@xxxxxxx>
Reviewed-by: Lijo Lazar <lijo.lazar@xxxxxxx>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c
> index 86958cb2c2ab..eafd8bcf2870 100644
> --- a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c
> @@ -743,14 +743,6 @@ void jpeg_v4_0_3_dec_ring_emit_fence(struct amdgpu_ring *ring, u64 addr, u64 seq
> amdgpu_ring_write(ring, PACKETJ(0, 0, 0, PACKETJ_TYPE6));
> amdgpu_ring_write(ring, 0);
>
> - amdgpu_ring_write(ring, PACKETJ(regUVD_JRBC_EXTERNAL_REG_INTERNAL_OFFSET,
> - 0, 0, PACKETJ_TYPE0));
> - amdgpu_ring_write(ring, 0x3fbc);
> -
> - amdgpu_ring_write(ring, PACKETJ(JRBC_DEC_EXTERNAL_REG_WRITE_ADDR,
> - 0, 0, PACKETJ_TYPE0));
> - amdgpu_ring_write(ring, 0x1);
> -
> amdgpu_ring_write(ring, PACKETJ(0, 0, 0, PACKETJ_TYPE6));
> amdgpu_ring_write(ring, 0);
>
> @@ -1088,7 +1080,7 @@ static const struct amdgpu_ring_funcs jpeg_v4_0_3_dec_ring_vm_funcs = {
> SOC15_FLUSH_GPU_TLB_NUM_WREG * 6 +
> SOC15_FLUSH_GPU_TLB_NUM_REG_WAIT * 8 +
> 8 + /* jpeg_v4_0_3_dec_ring_emit_vm_flush */
> - 22 + 22 + /* jpeg_v4_0_3_dec_ring_emit_fence x2 vm fence */
> + 18 + 18 + /* jpeg_v4_0_3_dec_ring_emit_fence x2 vm fence */
> 8 + 16,
> .emit_ib_size = 22, /* jpeg_v4_0_3_dec_ring_emit_ib */
> .emit_ib = jpeg_v4_0_3_dec_ring_emit_ib,
