[Public]
This patch is,
Reviewed-by: Tim Huang <tim.huang@xxxxxxx>
> -----Original Message-----
> From: Jesse.zhang@xxxxxxx <jesse.zhang@xxxxxxx>
> Sent: Thursday, September 5, 2024 5:21 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian
> <Christian.Koenig@xxxxxxx>; Huang, Tim <Tim.Huang@xxxxxxx>; Zhang,
> Jesse(Jie) <Jesse.Zhang@xxxxxxx>
> Subject: [PATCH] drm/amdkfd: clean up code for interrupt v10
>
> Variable hub_inst is unused.
> Related the commit "bde7ae79ca40":
> "drm/amdkfd: Drop poison hanlding from gfx v10"
>
> Signed-off-by: Jesse Zhang <jesse.zhang@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
> index bb8cbfc39b90..2db824e87c8a 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
> @@ -308,21 +308,8 @@ static void event_interrupt_wq_v10(struct kfd_node
> *dev,
> uint16_t ring_id =
> SOC15_RING_ID_FROM_IH_ENTRY(ih_ring_entry);
> uint32_t node_id =
> SOC15_NODEID_FROM_IH_ENTRY(ih_ring_entry);
> uint32_t vmid_type =
> SOC15_VMID_TYPE_FROM_IH_ENTRY(ih_ring_entry);
> - int hub_inst = 0;
> struct kfd_hsa_memory_exception_data exception_data;
>
> - /* gfxhub */
> - if (!vmid_type && dev->adev->gfx.funcs->ih_node_to_logical_xcc) {
> - hub_inst =
> dev->adev->gfx.funcs->ih_node_to_logical_xcc(dev->adev,
> - node_id);
> - if (hub_inst < 0)
> - hub_inst = 0;
> - }
> -
> - /* mmhub */
> - if (vmid_type && client_id == SOC15_IH_CLIENTID_VMC)
> - hub_inst = node_id / 4;
> -
> info.vmid = vmid;
> info.mc_id = client_id;
> info.page_addr = ih_ring_entry[4] |
> --
> 2.25.1
