On 9/4/2024 1:34 PM, Asher Song wrote:
> In some APUs, the bo type of GART page table is ttm_bo_type_sg.
> Those type BOs is released by bo->delayed_delete which is added in ttm_device->wq, not released immediately.
>
> To make sure all the ttm_resource is released before ttm_resource_manager is finilized, drain the workqueue in ttm_device.
>
> v2: move drain_workqueue to amdgpu_ttm.c
>
> Fixes:d99fbd9aab62 ("drm/ttm: Always take the bo delayed cleanup path for imported bos")
> Suggested-by: Christian König <christian.koenig@xxxxxxx>
> Signed-off-by: Asher Song <Asher.Song@xxxxxxx>
Acked-by: Lijo Lazar <lijo.lazar@xxxxxxx>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 5c938ff0bf48..cbac21df5c47 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -2461,6 +2461,7 @@ void amdgpu_ttm_fini(struct amdgpu_device *adev)
> drm_dev_exit(idx);
> }
>
> + drain_workqueue(adev->mman.bdev.wq);
> amdgpu_direct_gma_fini(adev);
> amdgpu_vram_mgr_fini(adev);
> amdgpu_gtt_mgr_fini(adev);
