[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (HP Hook G4 and Lenovo Thunderbolt Dock, both with 1x 4k60 DP and 1x 4k60 HDMI displays) * PCON (Club3D CAC-1085 and 1x 4k 144Hz) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - ffff173a20fe983726fe04debe60c0065e4b2e1d -> drm/amd/pm: ensure the fw_info is not null before using it) with new patches added on top of it. Tested on Ubuntu 24.04.1, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx> Thank you, Dan Wheeler Sr. Technologist | AMD SW Display ------------------------------------------------------------------------------------------------------------------ 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -----Original Message----- From: Mohamed, Zaeem <Zaeem.Mohamed@xxxxxxx> Sent: Wednesday, August 21, 2024 6:02 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>; Lin, Wayne <Wayne.Lin@xxxxxxx>; Gutierrez, Agustin <Agustin.Gutierrez@xxxxxxx>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@xxxxxxx>; Zuo, Jerry <Jerry.Zuo@xxxxxxx>; Mohamed, Zaeem <Zaeem.Mohamed@xxxxxxx>; Wheeler, Daniel <Daniel.Wheeler@xxxxxxx> Subject: [PATCH 00/16] DC Patches August 19, 2024 This DC patchset brings improvements in multiple areas. In summary, we have: * Fix MS/MP mismatches in dml21 for dcn401 * Resolved Coverity issues * Add back quality EASF and ISHARP and dc dependency changes * Add sharpness support for windowed YUV420 video * Add improvements for text display and HDR DWM and MPO * Fix Synaptics Cascaded Panamera DSC Determination * Allocate DCN35 clock table transfer buffers in GART * Add Replay Low Refresh Rate parameters in dc type Cc: Daniel Wheeler <daniel.wheeler@xxxxxxx> Ahmed, Muhammad (1): drm/amd/display: guard write a 0 post_divider value to HW Alvin Lee (2): drm/amd/display: Don't skip clock updates in overclocking drm/amd/display: Wait for all pending cleared before full update Aric Cyr (1): drm/amd/display: 3.2.298 Aurabindo Pillai (1): drm/amd/display: do not set traslate_by_source for DCN401 cursor ChunTao Tso (1): drm/amd/display: Retry Replay residency Daniel Sa (1): drm/amd/display: Resolve Coverity Issues Dennis Chan (1): drm/amd/display: Add Replay Low Refresh Rate parameters in dc type. Dillon Varone (1): drm/amd/display: Fix MS/MP mismatches in dml21 for dcn401 Fangzhi Zuo (2): drm/amd/display: Fix Synaptics Cascaded Panamera DSC Determination drm/amd/display: Add DSC Debug Log Nicholas Kazlauskas (2): drm/amd/display: Allocate DCN35 clock table transfer buffers in GART drm/amd/display: Notify DMCUB of D0/D3 state Samson Tam (3): drm/amd/display: add back quality EASF and ISHARP and dc dependency changes drm/amd/display: add improvements for text display and HDR DWM and MPO drm/amd/display: add sharpness support for windowed YUV420 video .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 18 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 133 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 5 +- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 6 +- .../dc/clk_mgr/dcn401/dcn401_clk_mgr.c | 3 - drivers/gpu/drm/amd/display/dc/core/dc.c | 4 + .../drm/amd/display/dc/core/dc_hw_sequencer.c | 9 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 2 - drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 30 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 24 +- .../gpu/drm/amd/display/dc/dc_spl_translate.c | 52 +- .../gpu/drm/amd/display/dc/dc_spl_translate.h | 1 + drivers/gpu/drm/amd/display/dc/dc_types.h | 19 + .../amd/display/dc/dccg/dcn35/dcn35_dccg.c | 3 +- .../gpu/drm/amd/display/dc/dce/dmub_replay.c | 18 +- .../dc/dml2/dml21/dml21_translation_helper.c | 11 +- .../display/dc/dml2/dml21/inc/dml_top_types.h | 1 - .../src/dml2_core/dml2_core_dcn4_calcs.c | 68 +- .../src/dml2_core/dml2_core_shared_types.h | 5 + .../dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c | 3 +- .../dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c | 3 - .../src/dml2_top/dml2_top_optimization.c | 1 - .../display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 568 +++--- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 4 +- .../amd/display/dc/hwss/dcn30/dcn30_hwseq.c | 27 + .../amd/display/dc/hwss/dcn30/dcn30_hwseq.h | 2 + .../amd/display/dc/hwss/dcn30/dcn30_init.c | 3 +- .../amd/display/dc/hwss/dcn301/dcn301_init.c | 1 + .../amd/display/dc/hwss/dcn32/dcn32_init.c | 1 + .../amd/display/dc/hwss/dcn401/dcn401_init.c | 1 + .../drm/amd/display/dc/hwss/hw_sequencer.h | 1 + .../amd/display/dc/inc/hw/timing_generator.h | 4 +- .../amd/display/dc/optc/dcn10/dcn10_optc.h | 9 + .../amd/display/dc/optc/dcn20/dcn20_optc.h | 7 +- .../amd/display/dc/optc/dcn30/dcn30_optc.c | 45 + .../amd/display/dc/optc/dcn30/dcn30_optc.h | 13 +- .../amd/display/dc/optc/dcn301/dcn301_optc.c | 3 + .../amd/display/dc/optc/dcn31/dcn31_optc.h | 9 +- .../amd/display/dc/optc/dcn314/dcn314_optc.h | 9 +- .../amd/display/dc/optc/dcn32/dcn32_optc.c | 16 +- .../amd/display/dc/optc/dcn32/dcn32_optc.h | 7 +- .../amd/display/dc/optc/dcn35/dcn35_optc.h | 6 +- .../amd/display/dc/optc/dcn401/dcn401_optc.c | 4 +- .../amd/display/dc/optc/dcn401/dcn401_optc.h | 6 +- .../dc/resource/dcn32/dcn32_resource.h | 3 +- .../dc/resource/dcn401/dcn401_resource.c | 7 + .../dc/resource/dcn401/dcn401_resource.h | 5 +- drivers/gpu/drm/amd/display/dc/spl/Makefile | 2 +- drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 1361 ++++++++----- .../drm/amd/display/dc/spl/dc_spl_filters.c | 15 + .../drm/amd/display/dc/spl/dc_spl_filters.h | 15 + .../display/dc/spl/dc_spl_isharp_filters.c | 460 ++++- .../display/dc/spl/dc_spl_isharp_filters.h | 35 +- .../display/dc/spl/dc_spl_scl_easf_filters.c | 1726 +++++++++++++++++ .../display/dc/spl/dc_spl_scl_easf_filters.h | 38 + .../amd/display/dc/spl/dc_spl_scl_filters.c | 91 +- .../amd/display/dc/spl/dc_spl_scl_filters.h | 55 +- .../display/dc/spl/dc_spl_scl_filters_old.c | 25 - .../gpu/drm/amd/display/dc/spl/dc_spl_types.h | 45 +- .../drm/amd/display/dc/spl/spl_custom_float.c | 151 ++ .../drm/amd/display/dc/spl/spl_custom_float.h | 29 + .../gpu/drm/amd/display/dc/spl/spl_debug.h | 25 + .../drm/amd/display/dc/spl/spl_fixpt31_32.c | 497 +++++ .../drm/amd/display/dc/spl/spl_fixpt31_32.h | 525 +++++ .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 38 +- 67 files changed, 5210 insertions(+), 1114 deletions(-) create mode 100644 drivers/gpu/drm/amd/display/dc/spl/dc_spl_filters.c create mode 100644 drivers/gpu/drm/amd/display/dc/spl/dc_spl_filters.h create mode 100644 drivers/gpu/drm/amd/display/dc/spl/dc_spl_scl_easf_filters.c create mode 100644 drivers/gpu/drm/amd/display/dc/spl/dc_spl_scl_easf_filters.h delete mode 100644 drivers/gpu/drm/amd/display/dc/spl/dc_spl_scl_filters_old.c create mode 100644 drivers/gpu/drm/amd/display/dc/spl/spl_custom_float.c create mode 100644 drivers/gpu/drm/amd/display/dc/spl/spl_custom_float.h create mode 100644 drivers/gpu/drm/amd/display/dc/spl/spl_debug.h create mode 100644 drivers/gpu/drm/amd/display/dc/spl/spl_fixpt31_32.c create mode 100644 drivers/gpu/drm/amd/display/dc/spl/spl_fixpt31_32.h -- 2.34.1