[AMD Official Use Only - AMD Internal Distribution Only]
Hi Alex,
Previously we used packed and found out it didn't match with FW interface, and the one without packed working as it matches with
FW interface, this sounds tricky though.
Thanks,
Ruijing
-----Original Message-----
From: Alex Deucher <alexdeucher@xxxxxxxxx>
Sent: Tuesday, August 6, 2024 3:45 PM
To: Yao, Yinjie <Yinjie.Yao@xxxxxxx>
Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liu, Leo <Leo.Liu@xxxxxxx>; Dong, Ruijing <Ruijing.Dong@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: Update kmd_fw_shared for VCN5
On Tue, Aug 6, 2024 at 3:38 PM yinjiyao <yinjie.yao@xxxxxxx> wrote:
>
> kmd_fw_shared changed in VCN5
>
> Signed-off-by: Yinjie Yao <yinjie.yao@xxxxxxx>
> Reviewed-by: Ruijing Dong <ruijing.dong@xxxxxxx>
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
BTW, should these structures be marked as packed? I suspect they should?
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
> index f127eccf59d7..2a1f3dbb14d3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
> @@ -464,8 +464,11 @@ struct amdgpu_vcn5_fw_shared {
> struct amdgpu_fw_shared_unified_queue_struct sq;
> uint8_t pad1[8];
> struct amdgpu_fw_shared_fw_logging fw_log;
> + uint8_t pad2[20];
> struct amdgpu_fw_shared_rb_setup rb_setup;
> - uint8_t pad2[4];
> + struct amdgpu_fw_shared_smu_interface_info smu_dpm_interface;
> + struct amdgpu_fw_shared_drm_key_wa drm_key_wa;
> + uint8_t pad3[9];
> };
>
> #define VCN_BLOCK_ENCODE_DISABLE_MASK 0x80
> --
> 2.34.1
>
