On Fri, Jul 26, 2024 at 9:50 AM Alex Deucher <alexander.deucher@xxxxxxx> wrote:
>
> This adds allocation latency, but aligns better with user
> expectations. The latency should improve with the drm buddy
> clearing patches that Arun has been working on.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index ebb3f87ef4f6..768840e8937d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -347,6 +347,10 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
> return -EINVAL;
> }
>
> + /* always clear VRAM */
> + if (args->in.domains & AMDGPU_GEM_DOMAIN_VRAM)
> + flags |= AMDGPU_GEM_CREATE_VRAM_CLEARED;
Alternatively, we can set AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE here,
although for cases like reboots, we probably want clear on create.
Alex
> +
> /* create a gem object to contain this object in */
> if (args->in.domains & (AMDGPU_GEM_DOMAIN_GDS |
> AMDGPU_GEM_DOMAIN_GWS | AMDGPU_GEM_DOMAIN_OA)) {
> --
> 2.45.2
>
