Re: [PATCH] drm/amdgpu: fix contiguous handling for IB parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Jul 2024 at 09:09, Dave Airlie <airlied@xxxxxxxxx> wrote:
>
> On Wed, 24 Jul 2024 at 23:32, Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
> >
> > On Wed, Jul 24, 2024 at 4:00 AM Christian König
> > <ckoenig.leichtzumerken@xxxxxxxxx> wrote:
> > >
> > > Otherwise we won't get correct access to the IB.
> > >
> > > Signed-off-by: Christian König <christian.koenig@xxxxxxx>
> >
> > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3501
> > Fixes: e362b7c8f8c7 ("drm/amdgpu: Modify the contiguous flags behaviour")
> >
> > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
>
> NAK (just capitialising to avoid it getting committed)
>
> This doesn't fix it, I think you also need
> AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS set as well.
>

It does work once you set both flags on the bo
(*bo)->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;

need to be added as well.

Dave.




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux