Hi David, changes to patches #8 and #10 look good to me, but Alex (or somebody else? Jerry?) should acknowledge these at least as well. Patch #11 is Reviewed-by: Christian König <christian.koenig at amd.com>. Patch #12 we need to clean this up a bit more, otherwise we will run into issue with mixed APUs+Vega10 systems (or even Vega10+older dGPU). Going to take care of this, but for now the patch is Reviewed-by: Christian König <christian.koenig at amd.com>. Patch #13, dito this needs cleanup. But for now Reviewed-by: Christian König <christian.koenig at amd.com>. All other patches are either from me or already reviewed. I would say wait till tomorrow for additional comments and then feel free to commit to amd-staging-4.9. Regards, Christian. Am 27.03.2017 um 07:53 schrieb Chunming Zhou: > *** BLURB HERE *** > From Vega, ascis start to support multiple level vmpt, the series is to implement it. > > Tested successfully with 2/3/4 levels. > > V2: address Christian comments. > > Max vm size 256TB tested ok. > > > Christian König (10): > drm/amdgpu: rename page_directory_fence to last_dir_update > drm/amdgpu: add the VM pointer to the amdgpu_pte_update_params as well > drm/amdgpu: add num_level to the VM manager > drm/amdgpu: generalize page table level > drm/amdgpu: handle multi level PD size calculation > drm/amdgpu: handle multi level PD during validation > drm/amdgpu: handle multi level PD in the LRU > drm/amdgpu: handle multi level PD updates V2 > drm/amdgpu: handle multi level PD during PT updates > drm/amdgpu: add alloc/free for multi level PDs V2 > > Chunming Zhou (5): > drm/amdgpu: abstract block size to one function > drm/amdgpu: limit block size to one page > drm/amdgpu: adapt vm size for multi vmpt > drm/amdgpu: set page table depth by num_level > drm/amdgpu: enable four level VMPT for gmc9 > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 67 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 474 +++++++++++++++++++---------- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 16 +- > drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 3 +- > drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 + > drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 2 +- > 11 files changed, 380 insertions(+), 200 deletions(-) >