Re: [PATCH 3/9] drm/amdkfd: Refactor queue wptr_bo GART mapping

[Philip Yang <yangp@xxxxxxx>]

On 2024-07-17 16:10, Felix Kuehling wrote:

> > @@ -603,8 +606,6
> >         @@ struct queue {
> >         
> >               void *gang_ctx_bo;
> >         
> >               uint64_t gang_ctx_gpu_addr;
> >         
> >               void *gang_ctx_cpu_ptr;
> >         
> >         -
> >         
> >         -    struct amdgpu_bo *wptr_bo;
> >         
> >       
>       
>       If the wptr_bo_gart is GART-mapped and freed in the same place as
>       the gang_ctx_bo, then maybe it makes sense to keep the two
>       together in this structure. It also avoids having two different
>       reference to the same BO in the same queue_properties structure
>       above.
>       
>

Yes, agree it makes sense to keep it inside struct queue and rename to wptr_bo_gart for GART mapping and unmapping. Add wptr_bo to struct queue_properties for queue wptr acquire and release.

Regards,

Philip

>       
>       Other than that, this patch looks good to me.
>       
>       
>       Regards,
>       
>         Felix
>       
>       
>       
> >   };
> >         
> >             enum KFD_MQD_TYPE {
> >       
>