[AMD Official Use Only - AMD Internal Distribution Only] -----Original Message----- From: Koenig, Christian <Christian.Koenig@xxxxxxx> Sent: Tuesday, July 2, 2024 2:25 PM To: Alex Deucher <alexdeucher@xxxxxxxxx>; Bhardwaj, Rajneesh <Rajneesh.Bhardwaj@xxxxxxx>; Maling list - DRI developers <dri-devel@xxxxxxxxxxxxxxxxxxxxx> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Kuehling, Felix <Felix.Kuehling@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx> Subject: Re: [PATCH 2/2] drm/ttm: Make ttm shrinkers NUMA aware Am 02.07.24 um 20:20 schrieb Alex Deucher: > + dri-devel > > On Tue, Jul 2, 2024 at 1:40 PM Rajneesh Bhardwaj > <rajneesh.bhardwaj@xxxxxxx> wrote: >> Otherwise the nid is always passed as 0 during memory reclaim so make >> TTM shrinkers NUMA aware. >> >> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxx> >> --- >> drivers/gpu/drm/ttm/ttm_pool.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_pool.c >> b/drivers/gpu/drm/ttm/ttm_pool.c index cc27d5c7afe8..f93ac9089a60 >> 100644 >> --- a/drivers/gpu/drm/ttm/ttm_pool.c >> +++ b/drivers/gpu/drm/ttm/ttm_pool.c >> @@ -812,7 +812,7 @@ int ttm_pool_mgr_init(unsigned long num_pages) >> &ttm_pool_debugfs_shrink_fops); >> #endif >> >> - mm_shrinker = shrinker_alloc(0, "drm-ttm_pool"); >> + mm_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE, >> + "drm-ttm_pool"); You also need to make ttm_pool_shrink() actually use the nid. Yeah, Did you mean setting the nid of the shrinker control structure from something like ttm_global_init() -passes NUMA node id dev_to_node(dev) to ttm_pool_mgr_init and use it to set the mm_shrinker->sc.nid ? Just setting the flag won't really help us. Regards, Christian. >> if (!mm_shrinker) >> return -ENOMEM; >> >> -- >> 2.34.1 >>
