[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - a2010c00faa46264d7722486609cd9a40aaffd69 -> drm/amd: Add some missing register definitions) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx> Thank you, Dan Wheeler Sr. Technologist | AMD SW Display ------------------------------------------------------------------------------------------------------------------ 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -----Original Message----- From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Fangzhi Zuo Sent: Thursday, June 27, 2024 5:13 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>; Lin, Wayne <Wayne.Lin@xxxxxxx>; Gutierrez, Agustin <Agustin.Gutierrez@xxxxxxx>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@xxxxxxx>; Zuo, Jerry <Jerry.Zuo@xxxxxxx>; Zuo, Jerry <Jerry.Zuo@xxxxxxx> Subject: [PATCH 00/26] DC Patches June 27th, 2024 This DC patchset brings improvements in multiple areas. In summary, we highlight: * FW Release 0.0.224.0 * Fix bw issue for dcn351 * Fix FAMS2 logic issue for dcn401 * Fix Coverity issues * Fix cursor issues * Refactor dio sources Alex Hung (3): drm/amd/display: Fix possible overflow in integer multiplication drm/amd/display: Check denominator pbn_div before used drm/amd/display: Check denominator crb_pipes before used Alvin Lee (1): drm/amd/display: Account for cursor prefetch BW in DML1 mode support Anthony Koo (1): drm/amd/display: Add replay state entry to replay_state Aric Cyr (1): drm/amd/display: 3.2.291 Bhuvanachandra Pinninti (1): drm/amd/display: Move dio files into dio folder Dillon Varone (1): drm/amd/display: Cleanup dce_get_dp_ref_freq_khz Fangzhi Zuo (2): drm/amd/display: Fix dmub timeout after fams2 enabled drm/amd/display: Update efficiency bandwidth for dcn351 George Shen (2): drm/amd/display: Fix divide by zero in CURSOR_DST_X_OFFSET calculation drm/amd/display: Add ASIC cap to limit DCC surface width Joshua Aberback (1): drm/amd/display: Remove unnecessary error message Nevenko Stupar (1): drm/amd/display: Adjust cursor visibility between MPC slices Nicholas Kazlauskas (1): drm/amd/display: Add debug option for disabling SLDO optimizations Paul Hsieh (1): drm/amd/display: un-block 8k with single dimm Roman Li (1): drm/amd/display: Fix array-index-out-of-bounds in dml2/FCLKChangeSupport Ryan Seto (1): drm/amd/display: Add available bandwidth calculation for audio (#16909) Sherry Wang (1): drm/amd/display: Skip unnecessary abm disable Sung Joon Kim (1): drm/amd/display: Choose HUBP unbounded request based on DML output Teeger (1): drm/amd/display: Revert Add workaround to restrict max frac urgent for DPM0 Tom Chung (3): drm/amd/display: Reset freesync config before update new state drm/amd/display: Add refresh rate range check drm/amd/display: Fix refresh rate range for some panel Wenjing Liu (1): drm/amd/display: fix a crash when clock source is reference for non otg master pipe Xi (Alex) Liu (1): drm/amd/display: replace CRTC disable function call .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 55 +++++++++++++++- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 4 +- .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 +- .../gpu/drm/amd/display/dc/basics/dce_calcs.c | 2 +- .../display/dc/clk_mgr/dce100/dce_clk_mgr.c | 2 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 +- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 4 +- .../dc/clk_mgr/dcn401/dcn401_clk_mgr.c | 38 ++++++------ .../gpu/drm/amd/display/dc/core/dc_resource.c | 8 +-- .../gpu/drm/amd/display/dc/core/dc_stream.c | 6 +- drivers/gpu/drm/amd/display/dc/dc.h | 4 +- .../gpu/drm/amd/display/dc/dce/dce_audio.c | 5 +- .../drm/amd/display/dc/dce/dce_clock_source.c | 8 +-- .../drm/amd/display/dc/dce/dce_panel_cntl.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 1 - drivers/gpu/drm/amd/display/dc/dcn20/Makefile | 1 - drivers/gpu/drm/amd/display/dc/dcn30/Makefile | 2 - drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 2 +- drivers/gpu/drm/amd/display/dc/dio/Makefile | 36 +++++++++++ .../dc/{ => dio}/dcn10/dcn10_link_encoder.c | 0 .../dc/{ => dio}/dcn10/dcn10_link_encoder.h | 0 .../dc/{ => dio}/dcn10/dcn10_stream_encoder.c | 0 .../dc/{ => dio}/dcn10/dcn10_stream_encoder.h | 0 .../dc/{ => dio}/dcn20/dcn20_link_encoder.c | 0 .../dc/{ => dio}/dcn20/dcn20_link_encoder.h | 0 .../dc/{ => dio}/dcn20/dcn20_stream_encoder.c | 0 .../dc/{ => dio}/dcn20/dcn20_stream_encoder.h | 0 .../{ => dio}/dcn30/dcn30_dio_link_encoder.c | 0 .../{ => dio}/dcn30/dcn30_dio_link_encoder.h | 0 .../dcn30/dcn30_dio_stream_encoder.c | 0 .../dcn30/dcn30_dio_stream_encoder.h | 0 .../{ => dio}/dcn31/dcn31_dio_link_encoder.c | 0 .../{ => dio}/dcn31/dcn31_dio_link_encoder.h | 0 .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 2 +- .../dc/dml/dcn32/display_mode_vba_32.c | 3 + .../amd/display/dc/dml2/dml21/dml21_wrapper.c | 7 ++- .../display/dc/dml2/dml2_translation_helper.c | 1 + .../gpu/drm/amd/display/dc/dml2/dml2_utils.c | 14 +---- .../drm/amd/display/dc/dml2/dml2_wrapper.c | 15 ----- .../drm/amd/display/dc/dml2/dml2_wrapper.h | 2 - .../display/dc/hubbub/dcn401/dcn401_hubbub.c | 6 ++ .../amd/display/dc/hubp/dcn401/dcn401_hubp.c | 15 ++++- .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 62 +++++++++++++++++-- .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 2 +- .../amd/display/dc/hwss/dcn21/dcn21_hwseq.c | 6 ++ .../amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 47 +++++++++++--- .../amd/display/dc/hwss/dcn401/dcn401_hwseq.h | 1 + .../link/protocols/link_edp_panel_control.c | 2 +- .../dc/resource/dcn314/dcn314_resource.c | 22 ------- .../dc/resource/dcn315/dcn315_resource.c | 2 +- .../dc/resource/dcn35/dcn35_resource.c | 2 - .../dc/resource/dcn401/dcn401_resource.c | 3 + drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 8 +-- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 5 +- .../gpu/drm/amd/display/dmub/src/dmub_dcn35.c | 1 + .../amd/display/modules/freesync/freesync.c | 2 +- 57 files changed, 287 insertions(+), 128 deletions(-) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn10/dcn10_link_encoder.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn10/dcn10_link_encoder.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn10/dcn10_stream_encoder.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn10/dcn10_stream_encoder.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn20/dcn20_link_encoder.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn20/dcn20_link_encoder.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn20/dcn20_stream_encoder.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn20/dcn20_stream_encoder.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn30/dcn30_dio_link_encoder.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn30/dcn30_dio_link_encoder.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn30/dcn30_dio_stream_encoder.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn30/dcn30_dio_stream_encoder.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn31/dcn31_dio_link_encoder.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn31/dcn31_dio_link_encoder.h (100%) -- 2.34.1