[AMD Official Use Only - AMD Internal Distribution Only] > -----Original Message----- > From: Lazar, Lijo <Lijo.Lazar@xxxxxxx> > Sent: Thursday, June 13, 2024 4:07 PM > To: Zhou1, Tao <Tao.Zhou1@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] drm/amdkfd: use mode1 reset for RAS poison consumption > > > > On 6/13/2024 12:27 PM, Tao Zhou wrote: > > Per FW requirement, replace mode2 with mode1. > > > > Signed-off-by: Tao Zhou <tao.zhou1@xxxxxxx> > > --- > > drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c > b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c > > index e1c21d250611..78dde62fb04a 100644 > > --- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c > > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c > > @@ -164,7 +164,7 @@ static void > event_interrupt_poison_consumption_v9(struct kfd_node *dev, > > case SOC15_IH_CLIENTID_SE3SH: > > case SOC15_IH_CLIENTID_UTCL2: > > block = AMDGPU_RAS_BLOCK__GFX; > > - reset = AMDGPU_RAS_GPU_RESET_MODE2_RESET; > > + reset = AMDGPU_RAS_GPU_RESET_MODE1_RESET; > > break; > > case SOC15_IH_CLIENTID_VMC: > > case SOC15_IH_CLIENTID_VMC1: > > @@ -177,7 +177,7 @@ static void > event_interrupt_poison_consumption_v9(struct kfd_node *dev, > > case SOC15_IH_CLIENTID_SDMA3: > > case SOC15_IH_CLIENTID_SDMA4: > > block = AMDGPU_RAS_BLOCK__SDMA; > > - reset = AMDGPU_RAS_GPU_RESET_MODE2_RESET; > > + reset = AMDGPU_RAS_GPU_RESET_MODE1_RESET; > > break; > > Does this need 9.4.3 IP version check? [Tao] It's applicable to all gfx9 ASICs. > > Thanks, > Lijo > > default: > > dev_warn(dev->adev->dev,