Re: [PATCH 1/2] drm/amdgpu: fix overflowed constant warning in mmhub_set_clockgating()

[Christian König <christian.koenig@xxxxxxx>]

Am 07.06.24 um 10:33 schrieb Bob Zhou:
> To fix potential overflowed constant warning, modify the variables to u32
> for getting the return value of RREG32_SOC15().
>
> Signed-off-by: Bob Zhou <bob.zhou@xxxxxxx>

Acked-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
> index 92432cd2c0c7..9689e2b5d4e5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
> @@ -544,7 +544,7 @@ static int mmhub_v1_7_set_clockgating(struct amdgpu_device *adev,
>   
>   static void mmhub_v1_7_get_clockgating(struct amdgpu_device *adev, u64 *flags)
>   {
> -	int data, data1;
> +	u32 data, data1;
>   
>   	if (amdgpu_sriov_vf(adev))
>   		*flags = 0;
> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
> index 02fd45261399..a0cc8e218ca1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
> @@ -671,7 +671,7 @@ static int mmhub_v2_0_set_clockgating(struct amdgpu_device *adev,
>   
>   static void mmhub_v2_0_get_clockgating(struct amdgpu_device *adev, u64 *flags)
>   {
> -	int data, data1;
> +	u32 data, data1;
>   
>   	if (amdgpu_sriov_vf(adev))
>   		*flags = 0;
> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c
> index 8928f9160822..b4ce3375d3fd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c
> @@ -613,7 +613,7 @@ static int mmhub_v3_3_set_clockgating(struct amdgpu_device *adev,
>   
>   static void mmhub_v3_3_get_clockgating(struct amdgpu_device *adev, u64 *flags)
>   {
> -	int data;
> +	u32 data;
>   
>   	if (amdgpu_sriov_vf(adev))
>   		*flags = 0;
> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> index 1b7da4aff2b8..ff1b58e44689 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> @@ -657,7 +657,7 @@ static int mmhub_v9_4_set_clockgating(struct amdgpu_device *adev,
>   
>   static void mmhub_v9_4_get_clockgating(struct amdgpu_device *adev, u64 *flags)
>   {
> -	int data, data1;
> +	u32 data, data1;
>   
>   	if (amdgpu_sriov_vf(adev))
>   		*flags = 0;