On Thu, Jun 06, 2024 at 10:21:07AM +0300, Jani Nikula wrote: > On Wed, 05 Jun 2024, Chris Bainbridge <chris.bainbridge@xxxxxxxxx> wrote: > > On Tue, Jun 04, 2024 at 10:02:29AM +0800, kernel test robot wrote: > >> Hi Mario, > >> > >> kernel test robot noticed the following build errors: > >> > >> [auto build test ERROR on drm-misc/drm-misc-next] > >> [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.10-rc2 next-20240603] > >> [If your patch is applied to the wrong git tree, kindly drop us a note. > >> And when submitting patch, we suggest to use '--base' as documented in > >> https://git-scm.com/docs/git-format-patch#_base_tree_information] > >> > >> url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/drm-client-Detect-when-ACPI-lid-is-closed-during-initialization/20240529-050440 > >> base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > >> patch link: https://lore.kernel.org/r/20240528210319.1242-1-mario.limonciello%40amd.com > >> patch subject: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization > >> config: i386-randconfig-053-20240604 (https://download.01.org/0day-ci/archive/20240604/202406040928.Eu1gRIWv-lkp@xxxxxxxxx/config) > >> compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 > >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240604/202406040928.Eu1gRIWv-lkp@xxxxxxxxx/reproduce) > >> > >> If you fix the issue in a separate patch/commit (i.e. not just a new version of > >> the same patch/commit), kindly add following tags > >> | Reported-by: kernel test robot <lkp@xxxxxxxxx> > >> | Closes: https://lore.kernel.org/oe-kbuild-all/202406040928.Eu1gRIWv-lkp@xxxxxxxxx/ > >> > >> All errors (new ones prefixed by >>): > >> > >> ld: drivers/gpu/drm/drm_client_modeset.o: in function `drm_client_match_edp_lid': > >> >> drivers/gpu/drm/drm_client_modeset.c:281:(.text+0x221b): undefined reference to `acpi_lid_open' > >> > >> > >> vim +281 drivers/gpu/drm/drm_client_modeset.c > >> > >> 260 > >> 261 static void drm_client_match_edp_lid(struct drm_device *dev, > >> 262 struct drm_connector **connectors, > >> 263 unsigned int connector_count, > >> 264 bool *enabled) > >> 265 { > >> 266 int i; > >> 267 > >> 268 for (i = 0; i < connector_count; i++) { > >> 269 struct drm_connector *connector = connectors[i]; > >> 270 > >> 271 switch (connector->connector_type) { > >> 272 case DRM_MODE_CONNECTOR_LVDS: > >> 273 case DRM_MODE_CONNECTOR_eDP: > >> 274 if (!enabled[i]) > >> 275 continue; > >> 276 break; > >> 277 default: > >> 278 continue; > >> 279 } > >> 280 > >> > 281 if (!acpi_lid_open()) { > >> 282 drm_dbg_kms(dev, "[CONNECTOR:%d:%s] lid is closed, disabling\n", > >> 283 connector->base.id, connector->name); > >> 284 enabled[i] = false; > >> 285 } > >> 286 } > >> 287 } > >> 288 > >> > >> -- > >> 0-DAY CI Kernel Test Service > >> https://github.com/intel/lkp-tests/wiki > > > > The failed config has CONFIG_ACPI_BUTTON=m. The build failure can be > > fixed with: > > > > diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c > > index b76438c31761..0271e66f44f8 100644 > > --- a/drivers/gpu/drm/drm_client_modeset.c > > +++ b/drivers/gpu/drm/drm_client_modeset.c > > @@ -271,11 +271,13 @@ static void drm_client_match_edp_lid(struct drm_device *dev, > > if (connector->connector_type != DRM_MODE_CONNECTOR_eDP || !enabled[i]) > > continue; > > > > +#if defined(CONFIG_ACPI_BUTTON) > > if (!acpi_lid_open()) { > > drm_dbg_kms(dev, "[CONNECTOR:%d:%s] lid is closed, disabling\n", > > connector->base.id, connector->name); > > enabled[i] = false; > > } > > +#endif > > } > > } > > No. This is because > > CONFIG_DRM=y > CONFIG_ACPI_BUTTON=m > > The pedantically correct fix is probably having DRM > > depends on ACPI_BUTTON || ACPI_BUTTON=n > > but seeing how i915 and xe just > > select ACPI_BUTTON if ACPI Huh. We should nuke that as we haven't used this lid stuff in ages. -- Ville Syrjälä Intel
