[AMD Official Use Only - AMD Internal Distribution Only] Hi Chris, I have checked my inbox and did not see your email. Could you please resend it? Best Regards, Kevin -----Original Message----- From: Koenig, Christian <Christian.Koenig@xxxxxxx> Sent: Wednesday, June 5, 2024 7:21 PM To: Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx> Subject: Re: [PATCH 00/18] Enhance amdgpu_firmware_request() to improve function flexibility You haven't addressed any of my comments on patch #1. Regards, Christian. Am 05.06.24 um 11:33 schrieb Wang, Yang(Kevin): > [AMD Official Use Only - AMD Internal Distribution Only] > > Ping... > > Best Regards, > Kevin > > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Yang Wang > Sent: Monday, June 3, 2024 9:42 AM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx> > Subject: [PATCH 00/18] Enhance amdgpu_firmware_request() to improve function flexibility > > Adding variable parameter support to function amdgpu_firmware_request() to improve function flexibility. > > Yang Wang (18): > drm/amdgpu: enhance amdgpu_ucode_request() function flexibility > drm/amdgpu: refine gpu_info firmware loading > drm/amdgpu: refine isp firmware loading > drm/amdgpu: refine mes firmware loading > drm/amdgpu: refine psp firmware loading > drm/amdgpu: refine sdma firmware loading > drm/amdgpu: refine imu firmware loading > drm/amdgpu: refine pmfw/smu firmware loading > drm/amdgpu: refine gmc firmware loading > drm/amdgpu: refine vcn firmware loading > drm/amdgpu: refine vpe firmware loading > drm/amdgpu: refine gfx6 firmware loading > drm/amdgpu: refine gfx7 firmware loading > drm/amdgpu: refine gfx8 firmware loading > drm/amdgpu: refine gfx9 firmware loading > drm/amdgpu: refine gfx10 firmware loading > drm/amdgpu: refine gfx11 firmware loading > drm/amdgpu: refine gfx12 firmware loading > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 ++- > drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 6 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 26 ++----- > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 8 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 30 +++++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 3 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 14 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 6 +- > drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 11 +-- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 25 ++++--- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 26 ++++--- > drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 22 +++--- > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 19 +++-- > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 27 ++++---- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 69 +++++++++---------- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 45 ++++++------ > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 11 ++- > drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 14 ++-- > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 +- > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 6 +- > drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 10 ++- > drivers/gpu/drm/amd/amdgpu/imu_v12_0.c | 10 ++- > drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 11 +-- > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 11 +-- > drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 8 +-- > .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 6 +- > .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 6 +- > .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 6 +- > .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 6 +- > 30 files changed, 205 insertions(+), 257 deletions(-) > > -- > 2.34.1 >