[AMD Official Use Only - AMD Internal Distribution Only] Hi Felix, Thanks for your review, and will drop the patch. Thanks Jesse -----Original Message----- From: Kuehling, Felix <Felix.Kuehling@xxxxxxx> Sent: Friday, May 31, 2024 4:40 AM To: Zhang, Jesse(Jie) <Jesse.Zhang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Kim, Jonathan <Jonathan.Kim@xxxxxxx>; Huang, Tim <Tim.Huang@xxxxxxx> Subject: Re: [PATCH 5/8] drm/amdkfd: fix the return for the function kfd_dbg_trap_set_flags On 2024-05-29 23:48, Jesse Zhang wrote: > If the rewind flag is set, it should return the final result of > setting mes debug mode or refresh the run list. No. We're rewinding because an error occurred. We want to return that error, not the success probably returned by refreshing the runlist. Regards, Felix > > Signed-off-by: Jesse Zhang <Jesse.Zhang@xxxxxxx> > --- > drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c > b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c > index 4abd275056d6..d12e5f29919a 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c > @@ -548,9 +548,9 @@ int kfd_dbg_trap_set_flags(struct kfd_process *target, uint32_t *flags) > continue; > > if (!pdd->dev->kfd->shared_resources.enable_mes) > - debug_refresh_runlist(pdd->dev->dqm); > + r = debug_refresh_runlist(pdd->dev->dqm); > else > - kfd_dbg_set_mes_debug_mode(pdd, true); > + r = kfd_dbg_set_mes_debug_mode(pdd, true); > } > } >
