> -----Original Message-----
> From: dri-devel <dri-devel-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Jani
> Nikula
> Sent: Friday, May 10, 2024 8:38 PM
> To: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; nouveau@xxxxxxxxxxxxxxxxxxxxx; intel-
> gfx@xxxxxxxxxxxxxxxxxxxxx; Nikula, Jani <jani.nikula@xxxxxxxxx>
> Subject: [RESEND 6/6] drm/connector: update edid_blob_ptr documentation
>
> Accessing the EDID via edid_blob_ptr causes chicken-and-egg problems. Keep
> edid_blob_ptr as the userspace interface that should be accessed via dedicated
> functions.
>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
LGTM
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@xxxxxxxxx>
> ---
> include/drm/drm_connector.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index fe88d7fc6b8f..58ee9adf9091 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -1636,8 +1636,12 @@ struct drm_connector {
>
> /**
> * @edid_blob_ptr: DRM property containing EDID if present.
> Protected by
> - * &drm_mode_config.mutex. This should be updated only by calling
> + * &drm_mode_config.mutex.
> + *
> + * This must be updated only by calling drm_edid_connector_update()
> or
> * drm_connector_update_edid_property().
> + *
> + * This must not be used by drivers directly.
> */
> struct drm_property_blob *edid_blob_ptr;
>
> --
> 2.39.2
