On 5/13/2024 4:27 PM, Lazar, Lijo wrote: > > > On 5/10/2024 8:20 AM, Jesse Zhang wrote: >> Check for specific indexes that may be invalid values. >> >> Signed-off-by: Jesse Zhang <Jesse.Zhang@xxxxxxx> >> --- >> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c >> index 051092f1b1b4..7c343dd12a7f 100644 >> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c >> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c >> @@ -2336,6 +2336,8 @@ static int smu_v13_0_6_mode2_reset(struct smu_context *smu) >> >> index = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_MSG, >> SMU_MSG_GfxDeviceDriverReset); >> + if (index < 0) >> + ret = -EINVAL; >> > > This check is unnecessary. This is IP specific logic and the index is > expected to exist. > If you are seeing a warning problem because of this, drop index and use PPSMC_MSG_GfxDriverReset directly. Thanks, Lijo > See this entry in smu_v13_0_6_message_map > > MSG_MAP(GfxDeviceDriverReset, PPSMC_MSG_GfxDriverReset, > SMU_MSG_RAS_PRI), > > > Thanks, > Lijo > >> mutex_lock(&smu->message_lock); >>
