Add Reviewed-by tag and address review comments on patch-2. Changes made: - Add Reviewed-by tag on patch-1 and 3. - Remove unwanted header files - Remove suprious lines, duplicate error prints - Fix multi-line comment style Pratap Nirujogi (3): drm/amd/amdgpu: Add ISP support to amdgpu_discovery drm/amd/amdgpu: Add ISP driver support drm/amd/amdgpu: Enable ISP in amdgpu_discovery drivers/gpu/drm/amd/amdgpu/Makefile | 3 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 23 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 278 ++++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h | 51 ++++ drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + drivers/gpu/drm/amd/include/amd_shared.h | 1 + 9 files changed, 370 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h -- 2.34.1