Re: [PATCH] drm/amdgpu/jpeg: keep drm kernel message consistent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 9, 2024 at 4:57 PM David (Ming Qiang) Wu <David.Wu3@xxxxxxx> wrote:
>
> amdgpu jpeg kernel message is different than others such as vcn:
>   [drm:jpeg_v5_0_0_hw_init [amdgpu]] JPEG decode initialized successfully.
>
> This patch is to make them consistent.
>
> The message after the change is:
>   [drm] JPEG decode initialized successfully.

Please convert the others to DRM_DEV_INFO instead.  Otherwise we can't
tell which GPUs these messages refer to on multi-GPU systems.

Alex

>
> Signed-off-by: David (Ming Qiang) Wu <David.Wu3@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c
> index 64c856bfe0cb..4be0668ab97d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c
> @@ -145,7 +145,7 @@ static int jpeg_v5_0_0_hw_init(void *handle)
>         if (r)
>                 return r;
>
> -       DRM_DEV_INFO(adev->dev, "JPEG decode initialized successfully.\n");
> +       DRM_INFO("JPEG decode initialized successfully.\n");
>
>         return 0;
>  }
> @@ -549,7 +549,7 @@ static const struct amdgpu_ring_funcs jpeg_v5_0_0_dec_ring_vm_funcs = {
>  static void jpeg_v5_0_0_set_dec_ring_funcs(struct amdgpu_device *adev)
>  {
>         adev->jpeg.inst->ring_dec->funcs = &jpeg_v5_0_0_dec_ring_vm_funcs;
> -       DRM_DEV_INFO(adev->dev, "JPEG decode is enabled in VM mode\n");
> +       DRM_INFO("JPEG decode is enabled in VM mode\n");
>  }
>
>  static const struct amdgpu_irq_src_funcs jpeg_v5_0_0_irq_funcs = {
> --
> 2.34.1
>




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux