Re: [PATCH 1/2] drm/amdgpu: fix ucode out-of-bounds read warning

[Alex Deucher <alexdeucher@xxxxxxxxx>]

On Mon, May 6, 2024 at 5:26 AM Tim Huang <Tim.Huang@xxxxxxx> wrote:
>
> Clear warning that read ucode[] may out-of-bounds.
>
> Signed-off-by: Tim Huang <Tim.Huang@xxxxxxx>

Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> index b8280be6225d..c3d89088123d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> @@ -213,6 +213,9 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device,
>                 struct amdgpu_firmware_info *ucode;
>
>                 id = fw_type_convert(cgs_device, type);
> +               if (id >= AMDGPU_UCODE_ID_MAXIMUM)
> +                       return -EINVAL;
> +
>                 ucode = &adev->firmware.ucode[id];
>                 if (ucode->fw == NULL)
>                         return -EINVAL;
> --
> 2.39.2
>