On 5/3/2024 07:05, fililip wrote:
This patch allows setting a low power cap if |ignore_min_pcap| is set to 1.
Signed-off-by: fililip <fililip6483@xxxxxxxxxxxxxx>
Rather than an attachment you should send the patch inline. That would
mean that your commit message and SoB should be at the top of the patch
itself.
If you're not aware of it, you should read through:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Basically a maintainer should be able to run:
'b4 shazam $URL'
And it would download the patch and apply it.
That being said my comments on the patch content:
As Alex mentioned a concern about the the maintenance of more
parameters, maybe it's worth making the sysfs file of the limit
"writable" instead.
Then when it's written the kernel driver can add_taint() for
TAINT_FIRMWARE_WORKAROUND when in use so we can see it clearly in logs.
