Re: [PATCH] drm/amd/amdxcp: Use unique name for partition dev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 30, 2024 at 8:32 AM Lijo Lazar <lijo.lazar@xxxxxxx> wrote:
>
> amdxcp is a platform driver for creating partition devices. libdrm
> library identifies a platform device based on 'OF_FULLNAME' or
> 'MODALIAS'. If two or more devices have the same platform name, drm
> library only picks the first device. Platform driver core uses name of
> the device to populate 'MODALIAS'. When 'amdxcp' is used as the base
> name, only first partition device gets identified. Assign unique name so
> that drm library identifies partition devices separately.
>
> amdxcp doesn't support probe of partitions, it doesn't bother about
> modaliases.
>
> Signed-off-by: Lijo Lazar <lijo.lazar@xxxxxxx>

Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c b/drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c
> index 90ddd8371176..b4131053b31b 100644
> --- a/drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c
> +++ b/drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c
> @@ -50,12 +50,14 @@ int amdgpu_xcp_drm_dev_alloc(struct drm_device **ddev)
>  {
>         struct platform_device *pdev;
>         struct xcp_device *pxcp_dev;
> +       char dev_name[20];
>         int ret;
>
>         if (pdev_num >= MAX_XCP_PLATFORM_DEVICE)
>                 return -ENODEV;
>
> -       pdev = platform_device_register_simple("amdgpu_xcp", pdev_num, NULL, 0);
> +       snprintf(dev_name, sizeof(dev_name), "amdgpu_xcp_%d", pdev_num);
> +       pdev = platform_device_register_simple(dev_name, -1, NULL, 0);
>         if (IS_ERR(pdev))
>                 return PTR_ERR(pdev);
>
> --
> 2.25.1
>




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux