Hi Christian, Thanks for your info. I missed them completely :( the va op raw func looks similar as my va op2. I will re-use them in hybrid libdrm and provide for UMD development. Regards, Jerry(Junwei Zhang) ________________________________________ From: Christian König <deathsimple@xxxxxxxxxxx> Sent: Thursday, March 16, 2017 5:28:21 PM To: Zhang, Jerry; amd-gfx at lists.freedesktop.org Subject: Re: [PATCH 0/4] [libdrm] support PRT and replace interface Am 16.03.2017 um 10:14 schrieb Zhang, Jerry: > Hi Christian, > > Thanks for your info. > Sorry to miss them... > > Actually this a serial of messed function patch, I should send them separately next time. > > If we support PRT with bo=NULL, we may need a new VA op. > So please take a look at patch 4: > * [PATCH 4/4] amdgpu: add a new bo va function to support NULL bo > > I also have a question about current VA op func, why we didn't use the input flags? I have no idea. > So I prepare the patch 2 to use the input flags: > * [PATCH 2/4] amdgpu: set va flag with input parameter Nicolai handled both issues by creating a new function where the BO is optional and the flags taken into account. Please take a look at his patches, they are on the mailing list. Christian. > > > Regards, > Jerry (Junwei Zhang) > > Linux Base Graphics > SRDC Software Development > _____________________________________ > > >> -----Original Message----- >> From: Christian König [mailto:deathsimple at vodafone.de] >> Sent: Thursday, March 16, 2017 17:00 >> To: Zhang, Jerry; amd-gfx at lists.freedesktop.org >> Subject: Re: [PATCH 0/4] [libdrm] support PRT and replace interface >> >> Nicolai already proposed patches for PRT support in libdrm (except the >> CLEAR/REPLACE addition). >> >> They look a bit cleaner and where posted first, I think we should use them >> instead. >> >> Christian. >> >> Am 16.03.2017 um 04:56 schrieb Junwei Zhang: >>> * add PRT flag and new VA op >>> * fix flag setting for current VA op function >>> * Why don't we set flag for current VA op function? >>> * [RFC] implement new VA fun to support NULL bo >>> >>> Junwei Zhang (4): >>> amdgpu: add new VA operations CLEAR and REPLACE >>> amdgpu: set va flag with input parameter >>> amdgpu: add PRT page attribute >>> amdgpu: add a new bo va function to support NULL bo >>> >>> amdgpu/amdgpu.h | 7 +++++++ >>> amdgpu/amdgpu_bo.c | 42 >> ++++++++++++++++++++++++++++++++++++++++-- >>> include/drm/amdgpu_drm.h | 4 ++++ >>> 3 files changed, 51 insertions(+), 2 deletions(-) >>>
