[AMD Official Use Only - General] > -----Original Message----- > From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx> > Sent: Wednesday, April 17, 2024 8:46 PM > To: Yang, Stanley <Stanley.Yang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH Review 1/1] drm/amdgpu: Support setting reset_method > at runtime > > Am 12.04.24 um 08:21 schrieb Stanley.Yang: > > Signed-off-by: Stanley.Yang <Stanley.Yang@xxxxxxx> > > You are missing a commit message, without it the patch will automatically be > rejected when you try to push it. Thank you Chris, will add it before push. Regards, Stanley > > With that added Reviewed-by: Christian König <christian.koenig@xxxxxxx> > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > index 80b9642f2bc4..5f5bf0c26b1f 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > @@ -915,7 +915,7 @@ module_param_named(freesync_video, > amdgpu_freesync_vid_mode, uint, 0444); > > * GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, > 3 = mode2, 4 = baco) > > */ > > MODULE_PARM_DESC(reset_method, "GPU reset method (-1 = auto > > (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = > > baco/bamaco)"); -module_param_named(reset_method, > amdgpu_reset_method, > > int, 0444); > > +module_param_named(reset_method, amdgpu_reset_method, int, 0644); > > > > /** > > * DOC: bad_page_threshold (int) Bad page threshold is specifies the