|
[AMD Official Use Only - General]
These changes are for vcn_unified_ring_test_ib which only used on VCN4 and VCN5. The only exception is ib_size_alignment of hw_ip_info.
The VCN5 adds address_patch_enabled in session_info. VCN4 doesn't have it, so it should just ignore the extra 0.
typedef struct uve_session_info_s
{
unsigned int interface_version; ///< The version of the firmware interface on which the host was built
unsigned int sw_context_address_hi; ///< High address of software context buffer
unsigned int sw_context_address_lo; ///< Low address of software context buffer
unsigned int address_patch_enabled; ///< address patching enabled in UMD
} uve_session_info_t;
By my tests, I didn't find error. I may need more tests on mi300 asic.
Thanks,
Sonny
From: Alex Deucher <alexdeucher@xxxxxxxxx>
Sent: Monday, April 15, 2024 5:32 PM To: Jiang, Sonny <Sonny.Jiang@xxxxxxx> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; Jiang, Sonny <Sonny.Jiang@xxxxxxx> Subject: Re: [PATCH 2/2] drm/amdgpu: IB test encode test package change for VCN5 On Mon, Apr 15, 2024 at 5:25 PM Sonny Jiang <sonny.jiang@xxxxxxx> wrote:
> > From: Sonny Jiang <sonjiang@xxxxxxx> > > VCN5 session info package interface changed > > Signed-off-by: Sonny Jiang <sonny.jiang@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > index 7d176046498f..e08aacacc43e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > @@ -882,7 +882,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand > ib->ptr[ib->length_dw++] = handle; > ib->ptr[ib->length_dw++] = upper_32_bits(addr); > ib->ptr[ib->length_dw++] = addr; > - ib->ptr[ib->length_dw++] = 0x0000000b; > + ib->ptr[ib->length_dw++] = 0x00000000; > > ib->ptr[ib->length_dw++] = 0x00000014; > ib->ptr[ib->length_dw++] = 0x00000002; /* task info */ > @@ -949,7 +949,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han > ib->ptr[ib->length_dw++] = handle; > ib->ptr[ib->length_dw++] = upper_32_bits(addr); > ib->ptr[ib->length_dw++] = addr; > - ib->ptr[ib->length_dw++] = 0x0000000b; > + ib->ptr[ib->length_dw++] = 0x00000000; These patches are touching common files, are these changes safe on pre-VCN5 IPs? Alex > > ib->ptr[ib->length_dw++] = 0x00000014; > ib->ptr[ib->length_dw++] = 0x00000002; > -- > 2.43.2 > |
