[AMD Official Use Only - General]
I think argument is more proper than signature here, with this fixed, the patch is:
Reviewed-by: Tao Zhou <tao.zhou1@xxxxxxx>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Yang
> Wang
> Sent: Thursday, March 28, 2024 1:53 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Wang, Yang(Kevin)
> <KevinYang.Wang@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: refine function signature of
> amdgpu_aca_get_error_data()
>
> refine function signature of amdgpu_aca_get_error_data();
>
> Signed-off-by: Yang Wang <kevinyang.wang@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 8 +++-----
> drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h | 6 +++++-
> 2 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> index 920ddbb35c3d..cb6a40a042e1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> @@ -525,10 +525,9 @@ static bool aca_handle_is_valid(struct aca_handle
> *handle) }
>
> int amdgpu_aca_get_error_data(struct amdgpu_device *adev, struct aca_handle
> *handle,
> - enum aca_error_type type, void *data, void *qctx)
> + enum aca_error_type type, struct ras_err_data
> *err_data,
> + struct ras_query_context *qctx)
> {
> - struct ras_err_data *err_data = (struct ras_err_data *)data;
> -
> if (!handle || !err_data)
> return -EINVAL;
>
> @@ -538,8 +537,7 @@ int amdgpu_aca_get_error_data(struct amdgpu_device
> *adev, struct aca_handle *han
> if (!(BIT(type) & handle->mask))
> return 0;
>
> - return __aca_get_error_data(adev, handle, type, err_data,
> - (struct ras_query_context *)qctx);
> + return __aca_get_error_data(adev, handle, type, err_data, qctx);
> }
>
> static void aca_error_init(struct aca_error *aerr, enum aca_error_type type) diff
> --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h
> index 247968d6a925..3765843ea648 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h
> @@ -26,6 +26,9 @@
>
> #include <linux/list.h>
>
> +struct ras_err_data;
> +struct ras_query_context;
> +
> #define ACA_MAX_REGS_COUNT (16)
>
> #define ACA_REG_FIELD(x, h, l) (((x) & GENMASK_ULL(h, l)) >>
> l)
> @@ -198,7 +201,8 @@ int amdgpu_aca_add_handle(struct amdgpu_device
> *adev, struct aca_handle *handle,
> const char *name, const struct aca_info *aca_info, void
> *data); void amdgpu_aca_remove_handle(struct aca_handle *handle); int
> amdgpu_aca_get_error_data(struct amdgpu_device *adev, struct aca_handle
> *handle,
> - enum aca_error_type type, void *data, void *qctx);
> + enum aca_error_type type, struct ras_err_data
> *err_data,
> + struct ras_query_context *qctx);
> int amdgpu_aca_smu_set_debug_mode(struct amdgpu_device *adev, bool en);
> void amdgpu_aca_smu_debugfs_init(struct amdgpu_device *adev, struct dentry
> *root); int aca_error_cache_log_bank_error(struct aca_handle *handle, struct
> aca_bank_info *info,
> --
> 2.34.1
