On 24.03.24 01:52, Alex Deucher wrote:
There are cases where soft reset seems to succeed, but
does not, so always use mode1/2 for now.
Does "for now" mean that a proper fix is being worked on/will appear later?
Immediately falling back to full resets is a really bad experience, and
it's especially catastrophic when only MODE1 is available.
Of course, soft resets succeeding but leaving the GPU in a faulty state
isn't acceptable either, but I think it's pretty important to keep the
ability to do soft resets if at all possible.
If it's not possible to wait with this until the proper fix is
available, I hope that at least it can be reverted soon.
Thanks,
Friedrich
Signed-off-by: Alex Deucher<alexander.deucher@xxxxxxx>
---
drivers/gpu/drm/amd/amdgpu/soc21.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c
index 581a3bd11481..8526282f4da1 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc21.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc21.c
@@ -457,10 +457,8 @@ static bool soc21_need_full_reset(struct amdgpu_device *adev)
{
switch (amdgpu_ip_version(adev, GC_HWIP, 0)) {
case IP_VERSION(11, 0, 0):
- return amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__UMC);
case IP_VERSION(11, 0, 2):
case IP_VERSION(11, 0, 3):
- return false;
default:
return true;
}
