Re: [PATCH] drm/amdgpu: fix the list movement

[Christian König <christian.koenig@xxxxxxx>]

Am 22.03.24 um 12:14 schrieb Shashank Sharma:
> This patch adds a fix for list object movement, which was
> introduced in the TLB flush series.
>
> Fixes: 0a29a49f3ed4 ("drm/amdgpu: sync page table freeing with tlb flush")
> Cc: Christian König <christian.koenig@xxxxxxx>
> Suggested-by: Christian König <christian.koenig@xxxxxxx>
> Signed-off-by: Shashank Sharma <shashank.sharma@xxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> index a0a5b955a4b4..7fdd306a48a0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> @@ -641,7 +641,7 @@ void amdgpu_vm_pt_free_list(struct amdgpu_device *adev,
>   
>   	if (unlocked) {
>   		spin_lock(&vm->status_lock);
> -		list_splice_init(&vm->pt_freed, &params->tlb_flush_waitlist);
> +		list_splice_init(&params->tlb_flush_waitlist, &vm->pt_freed);
>   		spin_unlock(&vm->status_lock);
>   		schedule_work(&vm->pt_free_work);
>   		return;