[AMD Official Use Only - General] Got it. Thanks for reported that. Sent the patch for review. Regards Sunil khatri -----Original Message----- From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Sent: Saturday, March 16, 2024 2:42 PM To: Khatri, Sunil <Sunil.Khatri@xxxxxxx> Cc: Khatri, Sunil <Sunil.Khatri@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [bug report] drm/amdgpu: add ring buffer information in devcoredump The static checker is just complaining about NULL checking that doesn't make sense. It raises the question, can the pointer be NULL or not? Based on your comments and from reviewing the code, I do not think it can be NULL. Thus the correct thing is to remove the unnecessary NULL check. regards, dan carpenter
