[AMD Official Use Only - General] Hi Alex, OK, got it. This patch will land with other smu v14.0.1 patches. And we are waiting for the IP review finished. Best Regards, Li > -----Original Message----- > From: Alex Deucher <alexdeucher@xxxxxxxxx> > Sent: Friday, March 8, 2024 10:30 PM > To: Ma, Li <Li.Ma@xxxxxxx> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander > <Alexander.Deucher@xxxxxxx>; Zhang, Yifan <Yifan1.Zhang@xxxxxxx>; > Yu, Lang <Lang.Yu@xxxxxxx>; Huang, Tim <Tim.Huang@xxxxxxx>; Zhang, > Jesse(Jie) <Jesse.Zhang@xxxxxxx> > Subject: Re: [PATCH] drm/amdgpu: enable smu block for smu v14_0_1 > > On Thu, Mar 7, 2024 at 10:43 PM Li Ma <li.ma@xxxxxxx> wrote: > > > > add smu 14 support for sum v14_0_1 > > > > Signed-off-by: Li Ma <li.ma@xxxxxxx> > > Reviewed-by: Yifan Zhang <yifan1.zhang@xxxxxxx>i > > I think we should hold off on this until the rest of the smu 14.0.1 code lands. > Otherwise we'll be enabling an incomplete implementation. > > Alex > > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > > index a07e4b87d4ca..54a0414f22f0 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > > @@ -1896,6 +1896,7 @@ static int > amdgpu_discovery_set_smu_ip_blocks(struct amdgpu_device *adev) > > amdgpu_device_ip_block_add(adev, &smu_v13_0_ip_block); > > break; > > case IP_VERSION(14, 0, 0): > > + case IP_VERSION(14, 0, 1): > > amdgpu_device_ip_block_add(adev, &smu_v14_0_ip_block); > > break; > > default: > > -- > > 2.25.1 > >
