Reviewed-by: Marek Olšák <marek.olsak@xxxxxxx> Marek On Fri, Mar 8, 2024 at 3:43 AM Christian König <christian.koenig@xxxxxxx> wrote: > > Am 07.03.24 um 20:04 schrieb Joshua Ashton: > > As we discussed before[1], soft recovery should be > > forwarded to userspace, or we can get into a really > > bad state where apps will keep submitting hanging > > command buffers cascading us to a hard reset. > > Marek you are in favor of this like forever. So I would like to request > you to put your Reviewed-by on it and I will just push it into our > internal kernel branch. > > Regards, > Christian. > > > > > 1: https://lore.kernel.org/all/bf23d5ed-9a6b-43e7-84ee-8cbfd0d60f18@xxxxxxxxx/ > > Signed-off-by: Joshua Ashton <joshua@xxxxxxxxx> > > > > Cc: Friedrich Vock <friedrich.vock@xxxxxx> > > Cc: Bas Nieuwenhuizen <bas@xxxxxxxxxxxxxxxxxxx> > > Cc: Christian König <christian.koenig@xxxxxxx> > > Cc: André Almeida <andrealmeid@xxxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > > index 4b3000c21ef2..aebf59855e9f 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > > @@ -262,9 +262,8 @@ amdgpu_job_prepare_job(struct drm_sched_job *sched_job, > > struct dma_fence *fence = NULL; > > int r; > > > > - /* Ignore soft recovered fences here */ > > r = drm_sched_entity_error(s_entity); > > - if (r && r != -ENODATA) > > + if (r) > > goto error; > > > > if (!fence && job->gang_submit) >
